Use OPENSSL_free for OpenSSL allocations to avoid crash #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenSSL functions, like
X509_NAME_oneline
, returns pointers to memory allocations created usingOPENSSL_malloc
. The documentation for OpenSSL hints that such allocations should be freed usingOPENSSL_free
and not the standardfree
. For example:In OpenSSL forks like BoringSSL and AWS-LC,
OPENSSL_malloc
returns a pointer that can't be freed byfree
, and when attempted will cause a panic:This PR updates
tls_free_conninfo
to properly free the issuer and subject information in order to improve compatibility with the OpenSSL forks.