fs: change position of uv_fs_lchown

Change the position of UV_LS_LCHOWN, moving it to the end in order to go around a bug due to it's initial position. The original position of UV_LS_LCHOWN broke ABI compat, causing a binary using UV_FS_REALPATH or UV_FS_COPYFILE to break, as the values point to wrong function. Refs: yarnpkg/yarn#6043 Fixes: #1908 PR-URL: #1913 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
libuv · Jul 7, 2018 · 4f43a86 · 4f43a86
1 parent f401e67
commit 4f43a86
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/docs/src/fs.rst b/docs/src/fs.rst
@@ -92,9 +92,9 @@ Data types
             UV_FS_READLINK,
             UV_FS_CHOWN,
             UV_FS_FCHOWN,
-            UV_FS_LCHOWN,
             UV_FS_REALPATH,
-            UV_FS_COPYFILE
+            UV_FS_COPYFILE,
+            UV_FS_LCHOWN
         } uv_fs_type;
 
 .. c:type:: uv_dirent_t

diff --git a/include/uv.h b/include/uv.h
@@ -1144,9 +1144,9 @@ typedef enum {
   UV_FS_READLINK,
   UV_FS_CHOWN,
   UV_FS_FCHOWN,
-  UV_FS_LCHOWN,
   UV_FS_REALPATH,
-  UV_FS_COPYFILE
+  UV_FS_COPYFILE,
+  UV_FS_LCHOWN
 } uv_fs_type;
 
 /* uv_fs_t is a subclass of uv_req_t. */