Skip to content

Commit

Permalink
test: increase upper bound in condvar_5
Browse files Browse the repository at this point in the history
Problem:
Upper bound on thread wakeup was set to 1.5 * (requested timeout).
On MacOS wakeup delay factors of 1.75 have been reported.

Solution:
Increase the bound to 5 * (requested timeout).

Refs: #1910
PR-URL: #1990
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information
davisjam authored and cjihrig committed Sep 19, 2018
1 parent b721891 commit bb1a49e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/test-condvar.c
Expand Up @@ -259,7 +259,7 @@ TEST_IMPL(condvar_5) {
* https://msdn.microsoft.com/en-us/library/ms687069(VS.85).aspx */
elapsed = after - before;
ASSERT(0.75 * timeout <= elapsed); /* 1.0 too large for Windows. */
ASSERT(elapsed <= 1.5 * timeout); /* 1.1 too small for OSX. */
ASSERT(elapsed <= 5.0 * timeout); /* MacOS has reported failures up to 1.75. */

worker_config_destroy(&wc);

Expand Down

0 comments on commit bb1a49e

Please sign in to comment.