1.0.0: ipv6 tests fail when they should skip/avoid

[jbergstroem]

I still get a lot of fails when disabling ipv6 in my linux kernel (3.17.2). Shouldn't these really be skips?

[%  13|+  34|-   0|T   0|S   0]: tcp_ping_pong_v6
`tcp_ping_pong_v6` failed: exit code 6
Output from process `tcp_ping_pong_v6`:
IPv6 not supported
Output from process `tcp_ping_pong_v6`:
Assertion failed in /tmp/libuv-1.0.0/test/test-ping-pong.c on line 176: !r
=============================================================
[%  25|+  61|-   1|T   0|S   0]: tcp_bind6_error_addrinuse
`tcp_bind6_error_addrinuse` failed: exit code 6
Output from process `tcp_bind6_error_addrinuse`:
Assertion failed in /tmp/libuv-1.0.0/test/test-tcp-bind6-error.c on line 47: r == 0
=============================================================
[%  25|+  61|-   2|T   0|S   0]: tcp_bind6_error_addrnotavail
`tcp_bind6_error_addrnotavail` failed: exit code 6
Output from process `tcp_bind6_error_addrnotavail`:
Assertion failed in /tmp/libuv-1.0.0/test/test-tcp-bind6-error.c on line 81: r == UV_EADDRNOTAVAIL
=============================================================
[%  26|+  62|-   3|T   0|S   0]: tcp_bind6_error_inval
`tcp_bind6_error_inval` failed: exit code 6
Output from process `tcp_bind6_error_inval`:
Assertion failed in /tmp/libuv-1.0.0/test/test-tcp-bind6-error.c on line 132: r == 0
=============================================================
[%  27|+  62|-   4|T   0|S   0]: tcp_bind6_localhost_ok
`tcp_bind6_localhost_ok` failed: exit code 6
Output from process `tcp_bind6_localhost_ok`:
Assertion failed in /tmp/libuv-1.0.0/test/test-tcp-bind6-error.c on line 157: r == 0
=============================================================
[%  30|+  68|-   5|T   0|S   0]: udp_dual_stack
`udp_dual_stack` failed: exit code 6
Output from process `udp_dual_stack`:
Assertion failed in /tmp/libuv-1.0.0/test/test-udp-ipv6.c on line 112: r == 0
=============================================================
[%  30|+  68|-   6|T   0|S   0]: udp_ipv6_only
`udp_ipv6_only` failed: exit code 6
Output from process `udp_ipv6_only`:
Assertion failed in /tmp/libuv-1.0.0/test/test-udp-ipv6.c on line 112: r == 0
=============================================================
[%  32|+  71|-   7|T   0|S   0]: udp_multicast_interface6
`udp_multicast_interface6` failed: exit code 6
Output from process `udp_multicast_interface6`:
Assertion failed in /tmp/libuv-1.0.0/test/test-udp-multicast-interface6.c on line 70: r == 0
=============================================================
[%  32|+  72|-   8|T   0|S   0]: udp_multicast_join6
`udp_multicast_join6` failed: exit code 6
Output from process `udp_multicast_join6`:
Assertion failed in /tmp/libuv-1.0.0/test/test-udp-multicast-join6.c on line 116: r == 0
=============================================================

Either skip compile/running them or perhaps introduce a convenience method that checks for ipv6 support before calling the functions through tests.

[saghul]

I'd say no. If you disable IPv6 it's not libuv's fault, the test suite should test as much as possible. There are some situations which are special, however, like running the test suite as root or not.

That said, I'd probably take a patch skipping those tests if IPv6 is not available, if you're up for it :-)

[txdv]

check if file /proc/net/if_inet6 exists

[saghul]

check if file /proc/net/if_inet6 exists

That's not cross platform. I guess using uv_interface_addresses and checking if there is any address with AF_INET6 family should be enough.

[saghul]

Tentatively closing as this should be fixed by #92. If any other test fails because of IPv6 connectivity please let us know. Cheers!