Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uv__get_osfhandle() public #1291

Closed
jviotti opened this issue Apr 5, 2017 · 2 comments
Closed

Make uv__get_osfhandle() public #1291

jviotti opened this issue Apr 5, 2017 · 2 comments

Comments

@jviotti
Copy link
Contributor

jviotti commented Apr 5, 2017

MSVCR is statically linked into node, which means that users can't pass file descriptors from nodejs add-ons to the JavaScript code, given that the file descriptor to handle map in the add-on is separate to the one statically linked into the node executable.

This was initially reported in nodejs/node#6369, where the suggestion was to make uv__get_osfhandle() public, so add-ons can make use of it, and resolve the file descriptor correctly.

Would such a change be accepted?

The contributing guide says:

The stable branch is effectively frozen; patches that change the libuv API/ABI or affect the run-time behavior of applications get rejected.

However I wonder what are your thoughts here, given that the public API will remain backwards compatible.

If this is not something you'd accept, would you mind suggesting an alternative to mitigate this issue?

Thanks in advance!

@moteus
Copy link
Contributor

moteus commented Apr 5, 2017

I think this related with #1121, #1119 and #1166

@saghul
Copy link
Member

saghul commented Apr 24, 2017

@jviotti Yeah, I think it's an acceptable change, specially since we are adding it in #1166. If you write a PR, take the code from there so we don't diverge master from v1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants