Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fix #11

Merged
merged 2 commits into from
Jan 16, 2018
Merged

Windows fix #11

merged 2 commits into from
Jan 16, 2018

Conversation

bkmartinjr
Copy link
Contributor

Changes all related to Windows port:

Note that fixing issue #6 requires a relatively new Node version. For details see nodejs/node#6369 and libuv/libuv#1291

@ozra
Copy link
Owner

ozra commented Dec 28, 2017

Thanks, I'll have a look tomorrow before the holiday craze continues :)

@ozra
Copy link
Owner

ozra commented Jan 16, 2018

Sorry to keep you waiting.
I'd prefer PR's on their own feature/fix branches, however I'll just merge and cleanup locally. I'll seek to clarify the information under the contribution header in the README.
Thanks a lot for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants