Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken building on windows with CMake Ninja generator. #4139

Closed
mizvekov opened this issue Sep 15, 2023 · 1 comment
Closed

Broken building on windows with CMake Ninja generator. #4139

mizvekov opened this issue Sep 15, 2023 · 1 comment

Comments

@mizvekov
Copy link
Contributor

Building on windows with Ninja generator is currently broken, caused by recent change: #2085

The changes in OUTPUT_NAME causes the rules for both shared and static libraries to try to generate a file with the same name, uv.lib, resulting in cmake generating an ill-formed build.ninja.

Ninja produces the following diagnostics:

ninja: error: build.ninja:1006: multiple rules generate uv.lib [-w dupbuild=err]

For reference, see the output of this failing job: https://github.com/libuv/libuv/actions/runs/6203070753/job/16843050538

@vtjnash
Copy link
Member

vtjnash commented Dec 12, 2023

Fixed by #4185

@vtjnash vtjnash closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants