Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add windows ubsan and clang workflows #4138

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

mizvekov
Copy link
Contributor

No description provided.

@mizvekov
Copy link
Contributor Author

FYI this is why the clang-windows job is failing: #4139

@vtjnash
Copy link
Member

vtjnash commented Oct 27, 2023

Does it work with #4185 now?

@mizvekov mizvekov changed the base branch from v1.x to jn/libuv_a October 27, 2023 23:33
@mizvekov
Copy link
Contributor Author

@vtjnash I just rebased, but this was no-test. There is something different with the MSVC CI now, compared to last month, where before 'Ninja' tool was available, now is not.
So we are failing before we even try to generate the build system, which does not test your changes.

@mizvekov
Copy link
Contributor Author

mizvekov commented Oct 28, 2023

@vtjnash Looks good now, we generate a valid ninja.build, which gets us farther than before.

Now it's failing still, for a different reason, not the one I intended originally. It's the same problem as this: microsoft/STL#3568
This issue is easy to work around though, there is a clang flag which makes the sanitizer CodeGen just emit traps instead of calls to the ubsan runtime. I will make this change soon enough, it's getting late here.

After that is working, I would expect this CI job to fail once again, but this time due to UB when running the windows tests, which is what I intended to demonstrate initially.

@mizvekov mizvekov changed the base branch from jn/libuv_a to master October 29, 2023 23:48
@mizvekov mizvekov force-pushed the ci_msvc_ubsan branch 4 times, most recently from c2565ed to 88231f7 Compare October 30, 2023 00:30
@mizvekov mizvekov changed the base branch from master to v1.x October 30, 2023 00:50
@mizvekov mizvekov force-pushed the ci_msvc_ubsan branch 3 times, most recently from c79f847 to f2ac3ea Compare October 30, 2023 03:17
Fixes error: incompatible pointer to integer conversion passing 'uv_os_fd_t' (aka 'void *')
             to parameter of type 'SOCKET' (aka 'unsigned long long')
@mizvekov
Copy link
Contributor Author

Alright, thanks for the review!
You can go ahead and merge this.

@vtjnash vtjnash merged commit 93efccf into libuv:v1.x Oct 30, 2023
37 checks passed
@mizvekov mizvekov deleted the ci_msvc_ubsan branch October 30, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants