-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add windows ubsan and clang workflows #4138
Conversation
FYI this is why the clang-windows job is failing: #4139 |
Does it work with #4185 now? |
@vtjnash I just rebased, but this was no-test. There is something different with the MSVC CI now, compared to last month, where before 'Ninja' tool was available, now is not. |
@vtjnash Looks good now, we generate a valid ninja.build, which gets us farther than before. Now it's failing still, for a different reason, not the one I intended originally. It's the same problem as this: microsoft/STL#3568 After that is working, I would expect this CI job to fail once again, but this time due to UB when running the windows tests, which is what I intended to demonstrate initially. |
c2565ed
to
88231f7
Compare
c79f847
to
f2ac3ea
Compare
Fixes error: incompatible pointer to integer conversion passing 'uv_os_fd_t' (aka 'void *') to parameter of type 'SOCKET' (aka 'unsigned long long')
f2ac3ea
to
dc69ab0
Compare
Alright, thanks for the review! |
No description provided.