Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuid() does not drop all privileges due to io_uring (CVE-2024-22017) #4416

Closed
felixonmars opened this issue May 22, 2024 · 5 comments
Closed

Comments

@felixonmars
Copy link
Contributor

felixonmars commented May 22, 2024

  • Version: 1.48.0
  • Platform: Linux build.archlinux.org 6.9.1-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 17 May 2024 16:56:38 +0000 x86_64 GNU/Linux

Node.js is currently patching libuv to get rid of io_uring due to this, and I find it strange that it was never mentioned here: nodejs/node@42e659c

As an Arch Linux packager of both libuv and node.js, I would like to find a way forward without having to use a patched libuv for node.js. I am not familiar with this specific problem, but I could imagine options like a runtime switch for io_uring, or maybe if the underlying issue could be addressed.

@felixonmars
Copy link
Contributor Author

Found some (maybe useful) thoughts from the node.js community: nodejs/node#52156 (comment)

@sarandha-com
Copy link

After upgrading node-gyp to 10.1.0-3 I no longer need use export UV_USE_IO_URING=0 before using yarn install or yarn build.
This was an issue yesterday where I always needed to use export UV_USE_IO_URING=0 for working with vite scripts through yarn, otherwise it would give me Text file Busy error but looks like it's fixed now?

@saghul
Copy link
Member

saghul commented Jun 1, 2024

For context, the original issue is being addressed here: #4421

@bnoordhuis
Copy link
Member

@santigimeno this was fixed by #4492, right? Node.js can drop the patch (and optionally switch to uv_loop_configure) once we release a new version.

@santigimeno
Copy link
Member

Sorry I missed this.

@santigimeno this was fixed by #4492, right? Node.js can drop the patch (and optionally switch to uv_loop_configure) once we release a new version.

Yes, you're right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants