unix: don't malloc in uv_thread_create() #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! LGTM if the CI and the compilers are happy. |
|
What exactly does this expression means - |
|
A void function which takes a pointer to a void* argument. See: http://man7.org/linux/man-pages/man3/pthread_create.3.html |
Simplify and optimize uv_thread_create() by casting the function pointer to the prototype that pthread_create() wants. Avoids the indirection of an intermediate callback and heap-allocating custom state that is really only there to placate the compiler. PR-URL: libuv#1094 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
bnoordhuis
force-pushed
the
unix-simplify-thread-create
branch
from
1ec0fe3
to
3064ae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and optimize uv_thread_create() by casting the function pointer
to the prototype that pthread_create() wants. Avoids the indirection of
an intermediate callback and heap-allocating custom state that is really
only there to placate the compiler.
CI: https://ci.nodejs.org/job/libuv-test-commit/154/