Update threadpool.rst #146
Conversation
|
LGTM but can you amend the commit log per the guidelines in CONTRIBUTING.md? |
almosnow
force-pushed
the
patch-1
branch
2 times, most recently
from
f2e235a
to
8dad909
Compare
|
Check it out 👌 |
| @@ -12,7 +12,11 @@ Its default size is 4, but it can be changed at startup time by setting the | |||
| ``UV_THREADPOOL_SIZE`` environment variable to any value (the absolute maximum | |||
| is 128). | |||
|
|
|||
| The threadpool is global and shared across all event loops. | |||
| The threadpool is global and shared across all event loops. When a particular | |||
| function makes use of the threadpool (i.e. when using uv_queue_work) libuv | |||
There was a problem hiding this comment.
Use :c:func:uv_queue_work so Sphix creates a link automagically.
|
The "subsystem" for the commit log should be "doc". |
almosnow
force-pushed
the
patch-1
branch
3 times, most recently
from
c2f33fa
to
bd85600
Compare
|
@saghul There it is and thanks for the reference about the threadpool handle. If everything's fine and you're going to merge, could it please be @bnoordhuis the one that does the commit? It would be nice for me. |
| @@ -12,7 +12,11 @@ Its default size is 4, but it can be changed at startup time by setting the | |||
| ``UV_THREADPOOL_SIZE`` environment variable to any value (the absolute maximum | |||
| is 128). | |||
|
|
|||
| The threadpool is global and shared across all event loops. | |||
| The threadpool is global and shared across all event loops. When a particular | |||
| function makes use of the threadpool (i.e. when using :c:func:uv_queue_work) | |||
There was a problem hiding this comment.
The correct syntax is:
:c:func:`uv_queue_work`
Note the backticks.
Sure, after that last nit Ben will do the honors :-) |
|
Ready. |
|
LGTM 👍 |
|
@almosnow I don't want to be that guy but... can you sign the commit with your real name? Thanks! |
Added an explanation about how does libuv implements the threadpool and why. This is so users know what behavior they should expect when they make use of threads. Related issue: libuv/libuv#145
|
Ok [Definitely learning a lot about git/github today] |
|
Thanks Alex, landed in ea5f1f9! |
Add 2 more signatures to NanMakeCallback
From here: #145
Just so that someone won't ask the same thing again.