Solaris: implement equivalent of getifaddrs() with ioctl() #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getifaddrs() is only available since Solaris 11. Older versions of Solaris have to use ioctl() to perform the equivalent task. If getifaddrs() is not available, SUNOS_NO_IFADDRS is defined.
|
cc @libuv/sunos - maybe one of you can review this? |
|
I am aware that Solaris is dying (https://www.theregister.co.uk/2017/09/04/oracle_layoffs_solaris_sparc_teams/) but some people may still be interested. |
|
cc @libuv/smartos - if you don't review, presumably no one will. |
|
@bnoordhuis I'll try to take a look, but since it doesn't seem to be relevant to SmartOS, it's not high in my list of priorities. |
|
There are conflicts and no sign-offs so I'm afraid there's nothing to do but close it out. Thanks anyway for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a first draft to fix the issue #1458
I wait for your feedbacks.
PS: why are you building with -std=gnu89 and not -std=c99 or -std=gnu99 ?
C99 has really nice features that allows to write cleaner code.