test: add fs_huge_copyfile test #1553
Conversation
It's interesting because these are the only two platforms that use system specific APIs for file copying. Are you saying it's not possible to copy files that large using the existing implementation? |
Not really |
test/test-list.h
Outdated
| @@ -275,6 +275,9 @@ TEST_DECLARE (fs_fstat) | |||
| TEST_DECLARE (fs_access) | |||
| TEST_DECLARE (fs_chmod) | |||
| TEST_DECLARE (fs_copyfile) | |||
| #if !defined(_WIN32) && !defined(_AIX) && !defined(__APPLE__) | |||
There was a problem hiding this comment.
Suggestion: define unconditionally and move the #if guard inside the function in test/test-fs-copyfile.c, doing a RETURN_SKIP on unsupported platforms?
santigimeno
force-pushed
the
copyfile_test
branch
2 times, most recently
from
1ae1997
to
1408987
Compare
|
Suggestion incorporated. CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/522/ |
santigimeno
force-pushed
the
copyfile_test
branch
from
1408987
to
829dddf
Compare
santigimeno
force-pushed
the
copyfile_test
branch
from
829dddf
to
ad035cf
Compare
It checks copying files larger than 0x7ffff000 works as expected. Refactor `touch_file()` function on `test-fs-copyfile.c` so it's faster. Disabled on some platforms for different reasons: - `OS X` and `Windows` as sometimes the test would timeout even after having expanded the allowed time. Also, we're specifically testing partial `sendfile()` calls which don't apply to these platforms. - `AIX` as apparently by default doesn't support files larger than 2GB. PR-URL: libuv#1596 Refs: libuv#1494 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
santigimeno
force-pushed
the
copyfile_test
branch
from
ad035cf
to
e815c5f
Compare
|
@santigimeno do you want to keep this open, or did you decide that some CI systems might make this not worth it? |
|
Yeah, it was terribly flaky. Let's close it for the moment. |
It checks copying files larger than 0x7ffff000 works as expected.
Refactor
touch_file()function ontest-fs-copyfile.cso it's faster.Disabled on some platforms for different reasons:
OS XandWindowsas sometimes the test would timeout even afterhaving expanded the allowed time. Also, we're specifically testing
partial
sendfile()calls which don't apply to these platforms.AIXas apparently by default doesn't support files larger than 2GB.Refs: #1494