build: split off tests into separate gyp file #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R=@cjihrig, maybe? |
cjihrig
approved these changes
Jan 27, 2018
Drop obsolete workarounds from the `gyp_uv.py` wrapper script. The bugs they work around were fixed about five years ago. PR-URL: libuv#1725 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Make it easier for Node.js to ship libuv in its tarballs without also including the test suite. Node.js already does so but recent changes to its build system complicate that. Kills two birds with one stone: it helps out Node.js and it makes it harder for us to introduce hidden dependencies between the library and the test suite. PR-URL: libuv#1725 Refs: nodejs/node#18287 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Cheers, landed in 83e1871...fdf7c2a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier for Node.js to ship libuv in its tarballs without also
including the test suite. Node.js already does so but recent changes
to its build system complicate that.
Kills two birds with one stone: it helps out Node.js and it makes it
harder for us to introduce hidden dependencies between the library and
the test suite.
Refs: nodejs/node#18287
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/691/
I had to apply some per-platform tweaks that are in separate commits for your reviewing pleasure.