win, fs: fix uv_fs_unlink for +R -A files #1774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uv_fs_unlink would fail for read-only files with Archive attribute cleared. This fixes this issue.
santigimeno
approved these changes
Mar 17, 2018
test/test-list.h
Outdated
| @@ -284,6 +284,9 @@ TEST_DECLARE (fs_access) | |||
| TEST_DECLARE (fs_chmod) | |||
| TEST_DECLARE (fs_copyfile) | |||
| TEST_DECLARE (fs_unlink_readonly) | |||
| #ifndef _WIN32 | |||
There was a problem hiding this comment.
s/#ifndef/#ifdef here and in the TEST_ENTRY definition
|
Updated, PTAL. CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/755/ |
3 tasks
|
Failures are unrelated. |
bzoz
added a commit
that referenced
this pull request
Mar 21, 2018
uv_fs_unlink would fail for read-only files with Archive attribute cleared. This fixes this issue. PR-URL: #1774 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
Landed in edf05b9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uv_fs_unlink would fail for read-only files with Archive attribute cleared. This fixes this issue.