win,tty: Added set cursor style to CSI sequences

[erw7]

This is for adding a set cursor style(CSI Ps SP q, CSI SP q) to handling of libuv escape sequence. This was originally created for neovim(neovim/neovim#8462).

Fix except 3. of #1874. I confirmed 3. with another terminal(xterm, mintty). Since another terminal accepted a sequence like CSI Ps ; Ps ; Ps H, I did not fix it.

[piscisaureus]

Generally seems reasonable, but I have a few comments.

Additionally, the repeated prev_utf8_codepoint != ' ' checks drive me crazy a little, it's kind difficult now to reason about state transitions now. Would it be possible to check for space at a single location, and maybe add an extra state flag (e.g. ANSI_DECSCUSR) similar to the ANSI_EXTENSION flag you just added?

[refack]

@erw7 any way to unit test this?

[erw7]

any way to unit test this?

I think that it is possible. But in order to do unit tests, I think that it is necessary to change uv__vterm_state to UV_UNSUPPORTED only during testing. Can I create a private function that does that setting? Or is there a better way?

[erw7]

I wrote the test and noticed the following things, please tell me about uv_tty_virtual_offset.

I think it is a bug to initialize uv_tty_virtual_offset with info->dwCursorPosition.Y, because the cursor position is not always on the first line of the display window. I think uv_tty_virtual_offset should be initialized with info->srWindow.Top. Is this idea correct?

If the above is correct, I think that uv_tty_virtual_offset is always equal to info->srWindows.Top. If so, are there any problems if we use info->srWindow.Top instead of uv_tty_virtual_offset?

[piscisaureus]

Nice work @erw7.
All these tests are awesome -- we have to get this in.

[piscisaureus]

Note that on windows 10 these tests don't all pass, because windows processes the escape sequences and not libuv. Maybe you can somehow forcefully enable libuv's escape sequence processing when running the tty tests?

test output

1..340
ok 1 - tty
ok 2 - tty_cursor_back
ok 3 - tty_cursor_down
ok 4 - tty_cursor_forward
ok 5 - tty_cursor_horizontal_move_absolute
ok 6 - tty_cursor_move_absolute
ok 7 - tty_cursor_next_line
ok 8 - tty_cursor_previous_line
ok 9 - tty_cursor_up
ok 10 - tty_empty_write
ok 11 - tty_erase
ok 12 - tty_erase_line
not ok 13 - tty_escape_sequence_processing
# exit code 3
# Output from process `tty_escape_sequence_processing`:
# line:1 col:1 expected character 'H' but found ' '
# line:1 col:2 expected character 'e' but found ' '
# line:1 col:3 expected character 'l' but found ' '
# line:1 col:4 expected character 'l' but found ' '
# line:1 col:5 expected character 'o' but found ' '
# line:1 col:6 expected character 'H' but found ' '
# line:1 col:7 expected character 'e' but found ' '
# line:1 col:8 expected character 'l' but found ' '
# line:1 col:9 expected character 'l' but found ' '
# line:1 col:10 expected character 'o' but found ' '
# Assertion failed in c:\users\bertbelder\d\libuv\test\test-tty-escape-sequence-processing.c on line 1362: compare_screen(&tty_out, &actual, &expect)
ok 14 - tty_file
ok 15 - tty_full_reset
ok 16 - tty_hide_show_cursor
ok 17 - tty_large_write
ok 18 - tty_pty
ok 19 - tty_raw
ok 20 - tty_save_restore_cursor_position
ok 21 - tty_set_cursor_shape
not ok 22 - tty_set_style
# exit code 3
# Output from process `tty_set_style`:
# line:23 col:77 expected character 'H' but found ' '
# line:23 col:77 expected attributes '0' but found '7'
# line:23 col:78 expected character 'e' but found ' '
# line:23 col:78 expected attributes '0' but found '7'
# line:23 col:79 expected character 'l' but found ' '
# line:23 col:79 expected attributes '0' but found '7'
# line:23 col:80 expected character 'l' but found ' '
# line:23 col:80 expected attributes '0' but found '7'
# line:23 col:81 expected character 'o' but found ' '
# line:23 col:81 expected attributes '0' but found '7'
# Assertion failed in c:\users\bertbelder\d\libuv\test\test-tty-escape-sequence-processing.c on line 1093: compare_screen(&tty_out, &actual, &expect)

[erw7]

Maybe you can somehow forcefully enable libuv's escape sequence processing when running the tty tests?

I think that tty tests use libuv escape sequence processing, because I call uv__set_vterm_state in the initialize_tty function and set UV_SUPPORTED for uv__vterm_state.

When I compiled with MSYS 2 MinGW 64-bit on WIndows 10 installed in Virtual Box, I passed the corresponding test.

[saghul]

@erw7 feel free to land!

[erw7]

Landed in 288a067, 73ca4ac.

[c42f]

Awesome, thanks @erw7 this is epic! Now this is in, revisiting scroll region handling seems more approachable.