test: fix compiler warnings #1956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: libuv is compiled with -Wunused-result. In two tests, read() is used for ordering and the rc is ignored because it doesn't matter. But -Wunused-result causes warnings in these cases. Fix: Provide a (very generous) check on the rc of read() in these cases.
cjihrig
pushed a commit
that referenced
this pull request
Sep 18, 2018
Problem: libuv is compiled with -Wunused-result. In two tests, read() is used for ordering and the rc is ignored because it doesn't matter. But -Wunused-result causes warnings in these cases. Fix: Provide a (very generous) check on the rc of read() in these cases. PR-URL: #1956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig
pushed a commit
that referenced
this pull request
Sep 18, 2018
Problem: libuv is compiled with -Wunused-result. In two tests, read() is used for ordering and the rc is ignored because it doesn't matter. But -Wunused-result causes warnings in these cases. Fix: Provide a (very generous) check on the rc of read() in these cases. PR-URL: #1956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in abe9e01 (fresh CI was OK: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1027/). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
libuv is compiled with -Wunused-result.
In two tests, read() is used for ordering and the
rc is ignored because it doesn't matter.
But -Wunused-result causes warnings in these cases.
Fix:
Provide a (very generous) check on the rc of read()
in these cases.