Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win,udp: fix incorrect error code returned from uv_udp_recv_start #1979

Closed
wants to merge 1 commit into from
Closed

win,udp: fix incorrect error code returned from uv_udp_recv_start #1979

wants to merge 1 commit into from

Conversation

squeek502
Copy link
Contributor

Fixes #1978

@santigimeno
Copy link
Member

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1022/
https://ci.nodejs.org/view/libuv/job/libuv-in-node/57/

cjihrig pushed a commit that referenced this pull request Sep 18, 2018
@squeek502 @cjihrig
win: fix uv_udp_recv_start() error translation
57b3363 
PR-URL: #1979
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@cjihrig
Copy link
Contributor

cjihrig commented Sep 18, 2018

Landed in 57b3363. Thanks!

@cjihrig cjihrig closed this Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santigimeno santigimeno santigimeno approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@squeek502 @santigimeno @cjihrig