win, doc: improve uv_os_setpriority documentation #1985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Sep 12, 2018
docs/src/misc.rst
Outdated
| @@ -544,4 +544,7 @@ API | |||
| process priority, the result will equal one of the `UV_PRIORITY` | |||
| constants, and not necessarily the exact value of `priority`. | |||
|
|
|||
| Setting PRIORITY_HIGHEST will only work for elevated user, for others it | |||
There was a problem hiding this comment.
Should PRIORITY_HIGHEST and PRIORITY_HIGH be in backticks? It also might be worth making this a separate note:: and emphasizing that this is a Windows thing.
|
Updated, PTAL |
|
Still LGTM, thanks! |
santigimeno
approved these changes
Sep 18, 2018
cjihrig
pushed a commit
that referenced
this pull request
Sep 18, 2018
Refs: nodejs/node#22817 PR-URL: #1985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
Landed in b721891. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/node#22817