linux: use copy_file_range for uv_fs_copyfile when possible #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarterLi
force-pushed
the
v1.x
branch
2 times, most recently
from
9ac78b7
to
5b3957d
Compare
bnoordhuis
reviewed
Jul 2, 2019
CarterLi
force-pushed
the
v1.x
branch
2 times, most recently
from
3e15794
to
f86f56f
Compare
|
Fixed, please review @bnoordhuis |
santigimeno
approved these changes
Aug 13, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
vtjnash
approved these changes
Jul 28, 2020
Refs: libuv#925 (comment) PR-URL: libuv#2352 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Jameson Nash <vtjnash@gmail.com>
|
CI for merge: https://ci.nodejs.org/job/libuv-test-commit/1960/ |
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
Refs: libuv#925 (comment) PR-URL: libuv#2352 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Jameson Nash <vtjnash@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the man page:
Thus copy_file_range may provide better performance on certain devices.
Tested on Linux archlinux-pc 5.1.15-arch1-1-ARCH
Ref: #925 (comment)