win: support retrieving empty env variables #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Aug 12, 2019
|
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1526/. None of the failures look related. |
bnoordhuis
approved these changes
Aug 13, 2019
Fixes: libuv#2413 PR-URL: libuv#2419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
uv__convert_utf8_to_utf16() always null terminates its UTF-16 output. This commit updates the code to use L'\0' as the terminator, instead of '\0'. Fixes: libuv#2413 PR-URL: libuv#2419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This commit adds Windows support for retrieving empty environment variables via uv_os_getenv(). Fixes: libuv#2413 PR-URL: libuv#2419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
3 tasks
erw7
pushed a commit
to erw7/libuv
that referenced
this pull request
Aug 19, 2019
This commit adds Windows support for retrieving empty environment variables via uv_os_getenv(). Fixes: libuv#2413 PR-URL: libuv#2419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7
pushed a commit
to erw7/libuv
that referenced
this pull request
Aug 19, 2019
uv__convert_utf8_to_utf16() always null terminates its UTF-16 output. This commit updates the code to use L'\0' as the terminator, instead of '\0'. Fixes: libuv#2413 PR-URL: libuv#2419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7
pushed a commit
to erw7/libuv
that referenced
this pull request
Aug 19, 2019
Fixes: libuv#2413 PR-URL: libuv#2419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7
pushed a commit
to erw7/libuv
that referenced
this pull request
Aug 19, 2019
This commit adds Windows support for retrieving empty environment variables via uv_os_getenv(). Fixes: libuv#2413 PR-URL: libuv#2419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7
pushed a commit
to erw7/libuv
that referenced
this pull request
Aug 19, 2019
uv__convert_utf8_to_utf16() always null terminates its UTF-16 output. This commit updates the code to use L'\0' as the terminator, instead of '\0'. Fixes: libuv#2413 PR-URL: libuv#2419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
erw7
pushed a commit
to erw7/libuv
that referenced
this pull request
Aug 19, 2019
Fixes: libuv#2413 PR-URL: libuv#2419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2413