test: disallow running the test suite as root #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’d merge and if there is a need we can add the escape hatch back maybe? |
|
Yes, that seems fine. |
|
I added back the escape hatch. If |
|
New CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1667/ (Looks OK) |
bnoordhuis
approved these changes
Dec 26, 2019
richardlau
approved these changes
Dec 26, 2019
The test suite is known to have issues when run as root. This commit prevents the test suite from running when the euid is 0. Fixes: libuv#2549 PR-URL: libuv#2585 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
cjihrig
force-pushed
the
no-root-tests
branch
from
9f05a92
to
af45b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite is known to have issues when run as root. This commit prevents the test suite from running when the euid is 0.
I'm not sure how the other maintainers will feel about this change, but people clearly don't read the GitHub issue template, so I thought this was worth a shot to prevent issues like #2549 (and many more).
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1666/ (looks like a normal libuv CI run)