build: turn on -fno-strict-aliasing #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Dec 29, 2019
richardlau
approved these changes
Dec 29, 2019
cjihrig
approved these changes
Dec 29, 2019
|
Well, note that it doesn't solve the whole problem, as some fields of the aliasing types are meant to be used directly. EDIT: now I see the README change :-) |
|
@bnoordhuis rebase and merge this? |
|
bump? |
Turn on `-fno-strict-aliasing` in libuv and add a note in the README for downstream projects. Fixes: libuv#1230 PR-URL: libuv#2588 Reviewed-By: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
|
Hopefully I got the cmake part correct in the rebase. |
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
Turn on `-fno-strict-aliasing` in libuv and add a note in the README for downstream projects. Fixes: libuv#1230 PR-URL: libuv#2588 Reviewed-By: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on
-fno-strict-aliasingand, in the case of the gyp build, exportit to projects that depend on libuv.
Fixes: #1230
CI: https://ci.nodejs.org/job/libuv-test-commit/1668/