src: add uv__reallocf() #2735
Closed
src: add uv__reallocf() #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modeled after FreeBSD's `reallocf(3)`: a version of `realloc(3)` that frees the memory when reallocation fails, simplifying error handling in many cases.
santigimeno
approved these changes
Mar 10, 2020
Comment on lines
+107
to
+109
| if (newptr == NULL) | ||
| if (size > 0) | ||
| uv__free(ptr); |
There was a problem hiding this comment.
Maybe wrapping these conditionals into one?
There was a problem hiding this comment.
You mean with &&? The two-if-statements style is pretty pervasive throughout libuv.
There was a problem hiding this comment.
Yeah, I meant that. It was just a suggestion. I'm fine either way.
addaleax
approved these changes
Mar 10, 2020
saghul
approved these changes
Mar 10, 2020
richardlau
approved these changes
Mar 10, 2020
cjihrig
approved these changes
Mar 10, 2020
cjihrig
pushed a commit
that referenced
this pull request
Mar 15, 2020
Modeled after FreeBSD's `reallocf(3)`: a version of `realloc(3)` that frees the memory when reallocation fails, simplifying error handling in many cases. PR-URL: #2735 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 1bcfbfd. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeled after FreeBSD's
reallocf(3): a version ofrealloc(3)thatfrees the memory when reallocation fails, simplifying error handling in
many cases.
CI: https://ci.nodejs.org/job/libuv-test-commit/1784/