android: fix memory overwriting in uv_interface_addresses() #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
reviewed
Apr 2, 2020
richardlau
approved these changes
Apr 3, 2020
devnexen
approved these changes
Apr 3, 2020
cjihrig
approved these changes
Apr 3, 2020
|
@linroid You're targeting master with this PR but you probably want to target the v1.x branch because that's where releases are cut from. I can't cherry-pick it to v1.x because it doesn't apply cleanly. Can you retarget this PR? Thanks. |
bnoordhuis
pushed a commit
that referenced
this pull request
Apr 6, 2020
PR-URL: #2767 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Never mind, I was able to merge it with some wedging. Landed in v1.x in commit 7656e98, thanks! |
ghost
pushed a commit
to termux/termux-packages
that referenced
this pull request
Apr 26, 2020
ghost
pushed a commit
to termux/termux-packages
that referenced
this pull request
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression of #2486.
For
IFA_ADDRESSandIFA_LOCALnetwork interface, we'll write two IP addresses toifaddrs:In that PR, it added a
break, then we only malloc one IP address memory space forl_entry, which leads to memory overwriting issue.