Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win: fix some MinGW warnings #2854

Merged
merged 5 commits into from
Aug 4, 2020
Merged

win: fix some MinGW warnings #2854

merged 5 commits into from
Aug 4, 2020

Commits on Aug 4, 2020

  1. win,nfc: fix integer comparison signedness 

    PR-URL: libuv#2854
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
    @escherstair @vtjnash
    escherstair authored and vtjnash committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    f6e74b1 View commit details
    Browse the repository at this point in the history

  2. win,nfc: use #pragma warnings() for MSVC only 

    PR-URL: libuv#2854
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Anna Henningsen <github@addaleax.net>
    @escherstair @addaleax @vtjnash
    2 people authored and vtjnash committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    ffca3fb View commit details
    Browse the repository at this point in the history

  3. win,nfc: removed some unused variables 

    PR-URL: libuv#2854
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
    @escherstair @vtjnash
    escherstair authored and vtjnash committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    98035e2 View commit details
    Browse the repository at this point in the history

  4. win,nfc: add missing return statement 

    PR-URL: libuv#2854
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
    @escherstair @vtjnash
    escherstair authored and vtjnash committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    3cd7ee7 View commit details
    Browse the repository at this point in the history

  5. win,nfc: disable clang-format for #include order 

    PR-URL: libuv#2854
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
    @escherstair @vtjnash
    escherstair authored and vtjnash committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    cc506dd View commit details
    Browse the repository at this point in the history