restore prctl on Linux #3019
Closed
restore prctl on Linux #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
LGTM, thanks.
So, it looks like I accidentally deleted that line in 7b28d36. I'm kind of surprised no one complained so far because it affects both Linux and macOS. - edit: someone did complain, I just missed it: nodejs/node#35503 :-)
santigimeno
approved these changes
Nov 5, 2020
richardlau
approved these changes
Nov 5, 2020
santigimeno
pushed a commit
to santigimeno/libuv
that referenced
this pull request
Dec 3, 2020
The call to `uv__set_process_title()` had been accidentally removed. Fixes: libuv#3037 PR-URL: libuv#3019 Refs: nodejs/node#35503 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
santigimeno
pushed a commit
to santigimeno/libuv
that referenced
this pull request
Dec 3, 2020
The call to `uv__set_process_title()` had been accidentally removed. Fixes: libuv#3037 PR-URL: libuv#3019 Refs: nodejs/node#35503 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in 9c6cec8. Thanks! |
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
The call to `uv__set_process_title()` had been accidentally removed. Fixes: libuv#3037 PR-URL: libuv#3019 Refs: nodejs/node#35503 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think that removing the prctl call on Linux was intentional?
see nodejs/node#35503