linux: fix epoll_pwait() fallback on arm64 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2015
|
LGTM |
arm64 doesn't have a epoll_wait() system call but a logic error stopped libuv from falling back to epoll_pwait(). This bug was introduced in commit 67bb2b5 ("linux: fix epoll_pwait() regression with < 2.6.19") which sadly exchanged one regression for another. PR-URL: libuv#308 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
bnoordhuis
force-pushed
the
fix-arm64-regression
branch
from
4f022ec
to
1d8332f
Compare
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Apr 7, 2015
arm64 doesn't have a epoll_wait() system call but a logic error stopped libuv from falling back to epoll_pwait(). This bug was introduced in commit libuv/libuv@67bb2b5 ("linux: fix epoll_pwait() regression with < 2.6.19") which sadly exchanged one regression for another. This commit is a back-port of libuv/libuv@1d8332f and should help get the ARMv8 buildbot in better shape. Original-PR-URL: libuv/libuv#308 PR-URL: nodejs#1365 Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis
added a commit
that referenced
this pull request
May 6, 2015
arm64 doesn't have a epoll_wait() system call but a logic error stopped libuv from falling back to epoll_pwait(). This bug was introduced in commit 67bb2b5 ("linux: fix epoll_pwait() regression with < 2.6.19") which sadly exchanged one regression for another. This is a backport of 1d8332f (v1.x) PR-URL: #308 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arm64 doesn't have a epoll_wait() system call but a logic error stopped
libuv from falling back to epoll_pwait().
This bug was introduced in commit 67bb2b5 ("linux: fix epoll_pwait()
regression with < 2.6.19") which sadly exchanged one regression for
another.
R=@saghul
https://jenkins-iojs.nodesource.com/view/libuv/job/libuv+any-pr+multi/75/