Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2435 Restore signal disposition to previous one #4216

Merged
merged 14 commits into from
Nov 15, 2023
Merged

#2435 Restore signal disposition to previous one #4216

merged 14 commits into from
Nov 15, 2023

Conversation

slavamuravey
Copy link
Contributor

@slavamuravey slavamuravey commented Nov 11, 2023 •
edited
Loading

Hi everyone! It is my first PR :) Glad to have the opportunity to contribute.

@slavamuravey
Copy link
Contributor Author

@bnoordhuis The PR fixes an issue #2435.

bnoordhuis
bnoordhuis reviewed Nov 13, 2023
View reviewed changes
src/unix/signal.c Outdated Show resolved Hide resolved
bnoordhuis
bnoordhuis reviewed Nov 14, 2023
View reviewed changes
src/unix/signal.c Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Nov 14, 2023
View reviewed changes
src/unix/signal.c Outdated Show resolved Hide resolved
bnoordhuis
bnoordhuis approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vtjnash you want to take another look or should I go ahead and merge?

@vtjnash
Copy link
Member

vtjnash commented Nov 14, 2023

There is a comment in one of the libuv test files that NSIG is not available on some of the supported platforms. This should perhaps deal with that case and make sure not to assign to this array outside of that case.

@bnoordhuis
Copy link
Member

bnoordhuis commented Nov 14, 2023 •
edited
Loading

That comment is about https://bugs.python.org/issue20584. Easiest workaround is to default to 128. There's no OS with more signals than that.

@vtjnash
Copy link
Member

vtjnash commented Nov 14, 2023

Using 128 hardcoded sounds good too. Just so long as we aren't using a value that is apparently known to be wrong here 😬

@slavamuravey
Copy link
Contributor Author

@bnoordhuis @vtjnash I'v pushed updates, now UV__NSIG constant equals to 128 is used instead of NSIG.

@slavamuravey
Copy link
Contributor Author

@bnoordhuis @vtjnash Is the PR ready to merge?

@bnoordhuis bnoordhuis merged commit b9421d7 into libuv:v1.x Nov 15, 2023
26 checks passed
@bnoordhuis
Copy link
Member

Merged, thanks!

@slavamuravey slavamuravey deleted the restore-signal-disposition branch November 15, 2023 13:41
santigimeno added a commit to santigimeno/libuv that referenced this pull request Feb 5, 2024
@santigimeno
Revert "unix: restore signal disposition to previous one (libuv#4216)"
46a5d00 
This reverts commit b9421d7.
santigimeno added a commit to santigimeno/libuv that referenced this pull request Feb 5, 2024
@santigimeno
Revert "unix: restore signal disposition to previous one (libuv#4216)"
4e3f71c 
This reverts commit b9421d7.

Refs: libuv#4299
Refs: libuv#4248
santigimeno added a commit that referenced this pull request Feb 6, 2024
@santigimeno
Revert "unix: restore signal disposition to previous one (#4216)" (#4302
10f3136 
)

This reverts commit b9421d7.

Refs: #4299
Refs: #4248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slavamuravey @vtjnash @bnoordhuis