linux: fix uv_available_parallelism using cgroup #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea why the ASAN build is failing ? |
bnoordhuis
reviewed
Jan 12, 2024
Closed
|
@bnoordhuis I fixed styling issues and added tests directly in test-platform-output.c. It might be a bit ugly though, happy to have your feedback on it To test it manually I built it with the following Dockerfile # Use the official Ubuntu base image
FROM ubuntu:20.04
# Update the package list
RUN apt-get update
# Install cmake and other build dependencies
RUN DEBIAN_FRONTEND=noninteractive apt-get install -y cmake libtool autoconf build-essential
# Fix : for some reason cmake is looking for gmake instead of make
RUN ln -s /usr/bin/make /usr/bin/gmake
# Set the working directory inside the container
WORKDIR /workspace
# Create a user 'libuv' and give ownership of /workspace to 'libuv'
RUN useradd -m libuv && chown -R libuv:libuv /workspace
# Switch to the 'libuv' user
USER libuv
# Copy the current directory contents into the container at /workspace
COPY --chown=libuv:libuv ./ /workspace/
# Run the build steps as 'libuv' user
RUN mkdir -p build
RUN (cd build && cmake .. -DBUILD_TESTING=ON)
RUN cmake --build build
# By default, run a shell
CMD ["/bin/sh", "-c", "/workspace/build/uv_run_tests platform_output"]And following commands $ docker build . libuv-test-cgroup
$ docker run --cpus="2" libuv-test-cgroup | grep available It correctly outputs 2 available cpus 
|
bnoordhuis
reviewed
Jan 26, 2024
|
@bnoordhuis have you other feedbacks ? |
|
Can you rebase on top of the v1.x branch? It looks like you're a few commits behind. |
waltoss
force-pushed
the
fix/uv_available_parallelism_cgroup
branch
from
f5bf3c6
to
deda40d
Compare
✅ |
uv_available_parallelism does not handle container cpu limit set by systems like Docker or Kubernetes. This patch fixes this limitation by comparing the amount of available cpus returned by syscall with the quota of cpus available defined in cgroup See issue: libuv#4146
Not working yet
waltoss
force-pushed
the
fix/uv_available_parallelism_cgroup
branch
from
deda40d
to
dd4d126
Compare
|
@bnoordhuis I rebased on v1.x |
bnoordhuis
approved these changes
Feb 12, 2024
santigimeno
approved these changes
Feb 12, 2024
|
@santigimeno @bnoordhuis any idea when this can be merged ? |
|
I'll go ahead and merge it. Thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #4146