Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:fix tty executables segment fault(#4303). #4322

Merged
merged 2 commits into from
Feb 28, 2024
Merged

docs:fix tty executables segment fault(#4303). #4322

merged 2 commits into from
Feb 28, 2024

Conversation

hiiizxf
Copy link
Contributor

@hiiizxf hiiizxf commented Feb 20, 2024

No description provided.

vtjnash
vtjnash requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to be better, since the lifetime of the first req still appears to be incorrect, and now the lifetime of the second req is also incorrect

@abidjappie abidjappie mentioned this pull request Feb 26, 2024
Closed
bnoordhuis
bnoordhuis approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@bnoordhuis bnoordhuis merged commit e8458b2 into libuv:v1.x Feb 28, 2024
3 checks passed
@hiiizxf hiiizxf deleted the mybranch branch March 1, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hiiizxf @bnoordhuis @vtjnash