win: almost fix race detecting ESRCH in uv_kill #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Mar 5, 2024
vtjnash
reviewed
Mar 5, 2024
vtjnash
reviewed
Mar 5, 2024
vtjnash
reviewed
Mar 5, 2024
|
I think this is done @vtjnash ptal, thanks |
vtjnash
approved these changes
Mar 5, 2024
It might happen that only using `WaitForSingleObject()` with timeout 0 could return WAIT_TIMEOUT as the process might not have been signaled yet. To improve things, first use `GetExitCodeProcess()` and check that `status` is not `STILL_ACTIVE`. Then, to cover for the case that the exit code was actually `STILL_ACTIVE` use `WaitForSingleObject()`. This could still be prone to the race condition but only for that case.
santigimeno
force-pushed
the
santi/win_kill_esrch
branch
from
09e1c46
to
0bbadb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might happen that only using
WaitForSingleObject()with timeout 0 could return WAIT_TIMEOUT as the process might not have been signaled yet. To improve things, first useGetExitCodeProcess()and check thatstatusis notSTILL_ACTIVE. Then, to cover for the case that the exit code was actuallySTILL_ACTIVEuseWaitForSingleObject(). This could still be prone to the race condition but only for that case.Fixes: nodejs/node#51766