Fix support for uClibc-ng #653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please adjust the commit message to the guidelines in CONTRIBUTING.md? Thanks! |
|
LGTM otherwise. |
uClibc-ng is currently at v1.0.9. The patch corrects the uClibc version test so that HAVE_IFADDRS_H is defined for uClibc versions after v0.9.32. Signed-off-by: Martin Bark <martin@barkynet.com>
martinbark
force-pushed
the
v1.x-fix-uclibc-ng
branch
from
e116adf
to
21dcb3a
Compare
|
Sorry about that, hopefully the commit message should be fixed now. |
saghul
pushed a commit
that referenced
this pull request
Dec 16, 2015
uClibc-ng is currently at v1.0.9. The patch corrects the uClibc version test so that HAVE_IFADDRS_H is defined for uClibc versions after v0.9.32. Signed-off-by: Martin Bark <martin@barkynet.com> PR-URL: #653 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
|
Landed in c861972, thanks! |
tpetazzoni
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Dec 23, 2015
See https://bugs.busybox.net/show_bug.cgi?id=8296 for further details on the origins of this bug. Submitted upstream to libuv and accepted, see libuv/libuv#653 and libuv/libuv@c861972 Signed-off-by: Martin Bark <martin@barkynet.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uClibc-ng is currently at v1.0.9. The patch corrects the uClibc
version test so that HAVE_IFADDRS_H is defined for uClibc versions
after v0.9.32.