unix: don't convert stat buffer when syscall fails #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Isn't memset kinda wasteful if the entire structure is going to be overwritten right after? I'd say we keep this patch as is. |
Don't call uv__to_stat() when the stat/fstat/lstat system call fails; the stack-allocated buffer contains only garbage in that case. Not a very serious bug it's technically undefined behavior and it made valgrind squawk. Introduced in commit 499c797 ("unix, windows: nanosecond resolution for uv_fs_[fl]stat"). PR-URL: libuv#921 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
|
LGTM as is. |
bnoordhuis
force-pushed
the
fix-stat-garbage
branch
from
da530f1
to
34ee257
Compare
The idea is that the caller doesn't see uninitialized values (and I'd implement it as OTOH (and IMO), it's arguably the caller's responsibility to check the return code. I wanted to present a balanced view. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't call uv__to_stat() when the stat/fstat/lstat system call fails;
the stack-allocated buffer contains only garbage in that case.
Not a very serious bug it's technically undefined behavior and it made
valgrind squawk.
Introduced in commit 499c797 ("unix, windows: nanosecond resolution
for uv_fs_[fl]stat").
Alternatively, we could
memset(pbuf, 0, sizeof(pbuf))before the system call. Thoughts?CI: https://ci.nodejs.org/job/libuv-test-commit/65/