New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add supported platforms description #991
Conversation
31139fb
to
aad36c3
Compare
/cc @libuv/collaborators |
I would like to add ">= V2R2" for z/OS version |
aad36c3
to
045ae1b
Compare
@jBarz done! |
045ae1b
to
5869187
Compare
Maybe add some direction on how to add a new platform and what to expected when you add one? |
@txdv Adding a new platform is a rare occurrence. It's typically a Unix variant, but I don't want to add a "Add your platform!" section because there are things we don't want to support: cygwin, for example. It all comes down to who is going to maintain those. AIX and z/OS are only there because IBM promised to maintain them. |
#### Note on FreeBSD 9 | ||
|
||
While FreeBSD is supported as Tier 1, FreeBSD 9 will get Tier 2 support until | ||
it reached EOL, in December 2016. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/reached/reaches/ and maybe replace 'EOL' with 'end of life' for people not familiar with the shorthand.
cc @misterdjules for the sunos/solaris status change. |
Fixed up the FreeBSD text and added a section about adding new platforms. PTAL. |
@bnoordhuis Thanks for the heads up! A couple of questions:
|
Ahoi!
There is no process in-place, we are here now trying to solve this dilemma :-) But yeah, given that SunOS / SmartOS is not that "mainstream" we need someone to step up and maintain it. Similar to how AIX and z/OS show on the table. As an example, I'm about to send a PR which breaks SmartOS (unintentionally, I swear!) and I honestly have no idea how to fix it at a quick glance. Who do I @ ?
AFAIK we have been treating them the same until now. We probably only support SmartOS, I guess. We could update the table and say we support SmartOS, that would mean that other Solaris derivatives fall into the "other" category. |
Absolutely, that makes sense.
You can definitely mention me, and I'll take a look asap.
Maybe Solaris could also be Tier 3? I don't know because I haven't used a Sun/Oracle Solaris operating system in a long time. Maybe someone from the Solaris community would be able to answer that question? |
Will do, thanks!
I guess, since we have been claiming to support it to me degree for a while.
I don't know anyone I'm afraid. Do you know someone we can contact? |
I don't. |
Is there a time frame you can commit to? With AIX and z/OS, I can at-mention a fellow IBM'er and I know it will be looked at (and most likely fixed) within 12 hours.
I'm okay with that if you can outline when and where there is a material difference. Libuv so far treated them as effectively interchangeable. |
I'm not sure it makes sense to commit to a time frame in terms of hours, since e.g you and @saghul are in a time zone that has a 8 or 9 hours difference with the time zone I live in. It also depends on the severity of the problem, and other factors (I can be on vacation, sick, etc.). But what I can guarantee is that I have been and I will respond reasonably quickly if I'm mentioned in an issue. One suggestion to make the communication easier would be to have a libuv/smartos team. I might be the only one in that team at the beginning, but I could try growing that team so that the project gets support on SmartOS specific questions/issues in a timely manner even if I'm not available. How does that sound? If that sounds reasonable, then we could start by pinging that team on every SmartOS specific issue. I would also suggest adding a
Sounds good. The differences are sometimes subtle but their impact is significant. I don't have a list ready at hand, but it would probably be a good thing to come up with one and maybe store it somewhere we can point people to. I'll see if I can come up with that list asap. |
I understand that of course. Those 12 hours are not a hard deadline, more an order of magnitude. To clarify, moving AIX and z/OS to tier 2 is a safe bet because IBM has resources on hand that ensure development is never blocked for long. When someone is sick or on holiday, there is always someone else who can take over. For SmartOS to be a tier 2 platform (let alone tier 1), a similar commitment is necessary.
Sounds reasonable to me. Other collaborators: agree/disagree? We should add labels for linux, freebsd, etc, as well. We currently only have osx and windows labels. |
We don't have teams other than collaborators as of yet, since they would be one person only. Maybe we can switch the note from "maintainer" to "overseer" (or something else) and add @misterdjules as the SunOS overseer? At least until we have more people to add to the team. |
Is there any problem with having teams of one person? I would see these teams as a label for one or more people who could do some work, and anyone could ping them without wondering if they should be ping one or more people. |
No problem at all, just a different approach :-) We could create libuv/{aix,sunos,zos} teams and the respective maintainers indeed. @bnoordhuis I get you are on board with with? Can do! |
Updated, PTAL. I put SunOS back at tier2 and mentioned teams as maintainers instead of individuals. If we all agree to this I'll go ahead and create the teams. |
| Windows | Tier 1 | Windows >= XP SP1 | MSVC 2008 and later are supported | | ||
| FreeBSD | Tier 1 | >= 9 (see note) | | | ||
| AIX | Tier 2 | >= 6 | Maintainer: @libuv/aix | | ||
| z/OS | Tier 2 | >= V2R2 | Maintainer: @libuv/zos | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Maintainer/Maintainers/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
LGTM |
a6a02fc
to
e0f5747
Compare
Updated. I'll leave this open a bit more in case other @libuv/collaborators want to weigh in. I went ahead and created @libuv/aix, @libuv/sunos and @libuv/zos, so @iwuzhere, @misterdjules and @jBarz you should've gotten an invite. |
LGTM2 |
e0f5747
to
be0e24c
Compare
Refs: libuv#991 Refs: libuv#1458 PR-URL: libuv#1469 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Rendered: https://github.com/saghul/libuv/blob/supported-platforms/SUPPORTED_PLATFORMS.md