Add --with-ffi-compat build option
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this, the "-static" variant distributes libvips as a single
shared library.
To ensure compatibility with the FFI-bindings, a new variant
("-static-ffi") is introduced, which continues to compile GLib as a
shared library.
kleisauke
commented
Sep 30, 2023
i686 symbols are prefixed with an underscore. ``` metadata.obj : error LNK2001: unresolved external symbol __imp__g_atomic_int_inc [C:\Users\kleisauke\sharp\build\sharp-win32-ia32.vcxproj] metadata.obj : error LNK2001: unresolved external symbol __imp__g_atomic_int_dec_and_test [C:\Users\kleisauke\sharp\build\sharp-win32-ia32.vcxproj] C:\Users\kleisauke\sharp\build\Release\sharp-win32-ia32.node : fatal error LNK1120: 2 unresolved externals [C:\Users\kleisauke\sharp\build\sharp-win32-ia32.vcxproj] ````
No longer needed after commit: lovell/sharp@70ac690
lovell
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, the "-static" variant distributes libvips as a single shared library.
To ensure compatibility with the FFI-bindings, a new variant ("-static-ffi") is introduced, which continues to compile GLib as a shared library.
Manually-tested with sharp using this changeset:
lovell/sharp@gauge...kleisauke:win32-single-shared