Rework rawsave and add rawsave_target (#3942)

* Rework rawsave and add rawsave_target * Close target after use * Add save to buffer * Deprecate rawsave_fd * Pick python executable from the path * Update function-list.xml
libvips · Apr 27, 2024 · 067b9f5 · 067b9f5
1 parent 90ab00a
commit 067b9f5
Show file tree

Hide file tree

Showing 6 changed files with 263 additions and 104 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,5 +1,6 @@
 master 8.16
 
+- add vips_rawsave_target(), vips_rawsave_buffer() [akash-akya]
 - allow small offsets for the PDF magic string [project0]
 - add support for OJPEG tiffs [DarthSim]
 - add "palette" metadata item to flag palette images [DarthSim]

diff --git a/doc/function-list.xml b/doc/function-list.xml
@@ -1247,9 +1247,14 @@
   <entry>vips_rawsave()</entry>
 </row>
 <row>
-  <entry>rawsave_fd</entry>
-  <entry>Write raw image to file descriptor</entry>
-  <entry>vips_rawsave_fd()</entry>
+  <entry>rawsave_buffer</entry>
+  <entry>Write raw image to buffer</entry>
+  <entry>vips_rawsave_buffer()</entry>
+</row>
+<row>
+  <entry>rawsave_target</entry>
+  <entry>Write raw image to target</entry>
+  <entry>vips_rawsave_target()</entry>
 </row>
 <row>
   <entry>recomb</entry>

diff --git a/doc/gen-function-list.py b/doc/gen-function-list.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python3
+#!/usr/bin/env python3
 
 # walk vips and generate a list of all operators and their descriptions
 # for docs

diff --git a/libvips/foreign/foreign.c b/libvips/foreign/foreign.c
@@ -3007,8 +3007,9 @@ vips_foreign_operation_init(void)
 	extern GType vips_foreign_save_tiff_target_get_type(void);
 
 	extern GType vips_foreign_load_raw_get_type(void);
-	extern GType vips_foreign_save_raw_get_type(void);
-	extern GType vips_foreign_save_raw_fd_get_type(void);
+	extern GType vips_foreign_save_raw_file_get_type(void);
+	extern GType vips_foreign_save_raw_buffer_get_type(void);
+	extern GType vips_foreign_save_raw_target_get_type(void);
 
 	extern GType vips_foreign_load_magick_file_get_type(void);
 	extern GType vips_foreign_load_magick_buffer_get_type(void);
@@ -3088,8 +3089,9 @@ vips_foreign_operation_init(void)
 	vips_foreign_print_matrix_get_type();
 
 	vips_foreign_load_raw_get_type();
-	vips_foreign_save_raw_get_type();
-	vips_foreign_save_raw_fd_get_type();
+	vips_foreign_save_raw_file_get_type();
+	vips_foreign_save_raw_buffer_get_type();
+	vips_foreign_save_raw_target_get_type();
 
 	vips_foreign_load_vips_file_get_type();
 	vips_foreign_load_vips_source_get_type();