Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shrink-on-load for openslide images #1149

Closed
jcupitt opened this issue Oct 31, 2018 · 3 comments
Closed

shrink-on-load for openslide images #1149

jcupitt opened this issue Oct 31, 2018 · 3 comments

Comments

@jcupitt
Copy link
Member

jcupitt commented Oct 31, 2018

The shrink-on-load logic in thumbnail does not have a path for openslide images.

We'd need to:

  • open the base image
  • read openslide.level-count to get the number of layers
  • starting from level_count - 1 (lowest res), step up the layers until we find one larger than the target (check openslide.level[level].width and .height)
  • perhaps should be larger by at least x2? though openslide levels are very spread out, so this could be very expensive
  • open that layer as the source image

See libvips/pyvips#72

jcupitt added a commit that referenced this issue Oct 31, 2018
makes vipsthumbnail much quicker on openslide images, obviously

see #1149
@jcupitt jcupitt closed this as completed Oct 31, 2018
@renexu
Copy link

renexu commented Jan 21, 2019

@jcupitt have you scheduled this enhancement in a future release? when will it be?
Thank you.

@jcupitt
Copy link
Member Author

jcupitt commented Jan 21, 2019

Yes, it's in 8.8, due in the next month or two. You can build git master and get it now if you want.

@renexu
Copy link

renexu commented Jan 21, 2019

Thank you @jcupitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants