-
-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
give icc_import / _export / _transform access to the new fallback profiles #1194
Comments
There's a branch here with this added: https://github.com/libvips/libvips/tree/add-icc-fallbacks It includes a built-in srgb profile as well as a cmyk one. Anywhere where https://github.com/libvips/libvips/tree/add-icc-fallbacks/libvips/colour/profiles Run it like this:
Still to do:
|
Added |
And the savers all use I think this is done! |
OK, merged to master. |
Does this work for Because this command seems to fail for me (on master): wget https://ory.weserv.nl/zebra.jpg
vips icc_export zebra.jpg x.v --output-profile=srgb
|
Oh, odd, yes, it should do. I expect I messed up, I'll have a look. |
some dead code needed removing #1194 (comment)
Yes, there was some code code that hadn't been moved to the new thing. Should be fixed now. Thanks! |
It still seems to refuse to produce output via the fallback ICC profile (on master). For example:
(same output with This worked fine on vips 8.7.4:
See #730 for more background information regarding this (I'm not sure if I had to open a new issue for this) |
libvips now has a built-in fallback CMYK profile for
vips_CMYK2XYZ()
. This should be available tovips_icc_import()
etc, as well, perhaps by giving the special stringcmyk
as a profile filename.We could add an sRGB fallback profile as well.
See #1186
The text was updated successfully, but these errors were encountered: