Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing images with more than 256 bands (hyperspectral)? #1335

Closed
erdmann opened this issue Jun 12, 2019 · 2 comments
Closed

Processing images with more than 256 bands (hyperspectral)? #1335

erdmann opened this issue Jun 12, 2019 · 2 comments

Comments

@erdmann
Copy link

erdmann commented Jun 12, 2019

Hi John,

I'm processing some 257-channel hyperspectral images (256 reflectances and a mask) and I encountered an error message that simply says "bad bands". I see that comes as a hard-coded limit of 256 bands here: arithmetic.c.

I would also like to start using vips to process raw files from our macro-XRF setup, which implies a need to deal in 4096-channel images.

The .v file format specification allocates 4 bytes for the band count, but I assume that the 256-band limit comes from 1 byte being allocated to store the band count somewhere internally. Is this a limitation that would be straightforward to extend?

Many thanks in advance.

jcupitt added a commit that referenced this issue Jun 12, 2019
there was a fixed-size array in vips__bandup()

see #1335
@jcupitt
Copy link
Member

jcupitt commented Jun 12, 2019

Hi, I removed that limit, it was just there for programming convenience. If you come across any more, please let me know.

@erdmann
Copy link
Author

erdmann commented Jun 12, 2019

I owe you so many beers. Thanks!

@erdmann erdmann closed this as completed Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants