Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vipsheader hangs on AFL generated input #1377

Closed
Kyle-Kyle opened this issue Jul 29, 2019 · 4 comments
Closed

vipsheader hangs on AFL generated input #1377

Kyle-Kyle opened this issue Jul 29, 2019 · 4 comments
Labels
bug in development

Comments

@Kyle-Kyle
Copy link

base64 encoded image content: UEYgNiAgMCAjRgEAGwAAAAMACzxa//8AABQAgP//ABEIAPsBIBvtIooA+vA=
@Kyle-Kyle Kyle-Kyle changed the title hangs on AFL generated input vipsheader hangs on AFL generated input Jul 29, 2019
@Kyle-Kyle
Copy link
Author

command line:
./.libs/vipsheader <input_image>

@jcupitt
Copy link
Member

jcupitt commented Jul 29, 2019

Hello @Kyle-Kyle ,

I see this too with:

$ echo UEYgNiAgMCAjRgEAGwAAAAMACzxa//8AABQAgP//ABEIAPsBIBvtIooA+vA= | base64 -d > x
$ vipsheader x

It looks like it's trying to read the ppm header and failing. Thanks for reporting this!

jcupitt added a commit that referenced this issue Jul 29, 2019
@jcupitt
fix loop with malformed ppm
5e77ab9 
skip_line in ppm parse was not testing for EOF, so it could get stuck
with malformed files

thanks Kyle-Kyle

see #1377
@jcupitt
Copy link
Member

jcupitt commented Jul 29, 2019

OK, fixed in 8.8, this will be in 8.8.2. Thank you very much for reporting this dumbness!

@jcupitt jcupitt closed this as completed Jul 29, 2019
@lovell
Copy link
Member

lovell commented Jul 29, 2019

libvips compiled using the --without-ppm flag is not affected by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug in development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lovell @jcupitt @Kyle-Kyle