Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gifload_buffer: Wrong record type detected #1404

Closed
revathi-murali opened this issue Aug 23, 2019 · 7 comments
Closed

gifload_buffer: Wrong record type detected #1404

revathi-murali opened this issue Aug 23, 2019 · 7 comments

Comments

@revathi-murali
Copy link

revathi-murali commented Aug 23, 2019

When vips_gifload_buffer is called internally from my project, I get the following error:

vips_realpath: unable to form filename\nunix error: No such file or directory\ngifload_buffer: Wrong record type detected\

We use giflib alpine package - https://pkgs.alpinelinux.org/package/edge/main/armhf/giflib

Note: The same gif file was working fine in vips - 8.7.4 but getting the error after upgrading to - 8.8.1.

Please refer to the below sample gif file that causes the error:

PIL-V_AN

jcupitt added a commit that referenced this issue Aug 23, 2019
Some GIFs don't follow the standard very closely. Let them through.

See #1404
@jcupitt
Copy link
Member

jcupitt commented Aug 23, 2019

I relaxed the rules for GIT parsing a bit and it works now. Thanks for the report!

This will be in 8.8.2.

@revathi-murali
Copy link
Author

When 8.8.2 will be released?

@jcupitt
Copy link
Member

jcupitt commented Aug 23, 2019

No idea! Maybe a week or two?

@revathi-murali
Copy link
Author

revathi-murali commented Aug 26, 2019

After applying the patch 4b677fb, I get a different error for the sample gif below:

vips_realpath: unable to form filename
unix error: No such file or directory
gifload_buffer: bad frame size

PAINT

Something is wrong with the gif image? Note: The same gif was working fine in v8.7.4.

@jcupitt
Copy link
Member

jcupitt commented Aug 26, 2019

Thanks for the new example -- I relaxed the rules again and your brush GIF loads now.

25e4577

@jcupitt
Copy link
Member

jcupitt commented Aug 26, 2019

And the moose.

@jcupitt
Copy link
Member

jcupitt commented Sep 1, 2019

OK, I think this is all working now, I'll close.

@jcupitt jcupitt closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants