Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image saving hangs if leaks detection is enabled #1542

Closed
DarthSim opened this issue Jan 31, 2020 · 2 comments
Closed

Image saving hangs if leaks detection is enabled #1542

DarthSim opened this issue Jan 31, 2020 · 2 comments
Labels
bug in development

Comments

@DarthSim
Copy link
Contributor

After I upgraded to 8.9.1 from 8.8.3, image saving started to hang if vips_leak_set(TRUE) was called before. Everything before the saving works as expected.

vipsthumbnail -v --size=200 image.jpg --vips-leak=1 hangs as well.
jcupitt added a commit that referenced this issue Jan 31, 2020
@jcupitt
fix a deadlock with --vips-leak
e4db747 
We were usingh a global lock for metadata changes, but some functions
triggered from callbacks in the metadata hash table could also attempt
to acquire the same mutex, leading to deadlock.

This patch gives metadata change it's own lock. Thanks DarthSim.

See #1542
@jcupitt
Copy link
Member

jcupitt commented Jan 31, 2020

This one at least was simple. Thanks for the report, fix in 8.9.2.

@jcupitt jcupitt closed this as completed Jan 31, 2020
@DarthSim
Copy link
Contributor Author

Wow, that was fast! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug in development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DarthSim @jcupitt