Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve vips__random #2642

Closed
jcupitt opened this issue Feb 2, 2022 · 2 comments
Closed

improve vips__random #2642

jcupitt opened this issue Feb 2, 2022 · 2 comments
Labels
bug

Comments

@jcupitt
Copy link
Member

jcupitt commented Feb 2, 2022

libvips uses a fast random number generator for operations like gaussnoise. It could use a bit of polish :/

vips gaussnoise x.png 512 512 --mean 128 --sigma 25

Generates:

x

See: http://isthe.com/chongo/tech/comp/fnv/#FNV-source
@jcupitt jcupitt added the bug label Feb 2, 2022
@jcupitt jcupitt mentioned this issue Feb 2, 2022
Closed
jcupitt added a commit that referenced this issue Feb 2, 2022
@jcupitt
improve the pixel rng
8c66830 
see #2642
@jcupitt
Copy link
Member Author

jcupitt commented Feb 2, 2022

I revised it very quickly, I now see:

x

@jcupitt jcupitt closed this as completed Feb 2, 2022
@mhirsch
Copy link

mhirsch commented Feb 2, 2022

Wow! That was a fast (but not random) response! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhirsch @jcupitt