Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icc_transform: incompatible profile isn't ignored #3139

Closed
dloebl opened this issue Nov 3, 2022 · 1 comment
Closed

icc_transform: incompatible profile isn't ignored #3139

dloebl opened this issue Nov 3, 2022 · 1 comment
Labels

Comments

@dloebl
Copy link
Contributor

dloebl commented Nov 3, 2022

Since 1297f2c incompatible source profiles do not seem to be ignored anymore:

Before 1297f2c:

$ vips icc_transform --input-profile=sRGB.icm test.jpg bef.jpg sRGB.icm

(vips:9111): VIPS-WARNING **: 10:55:58.075: profile incompatible with image
original output
test bef

Current master (17ca29a):

$ vips icc_transform --input-profile=sRGB.icm test.jpg now.jpg sRGB.icm
original output
test now

sRGB.icm
test.jpg

$ vipsheader test.jpg
test.jpg: 640x426 uchar, 4 bands, cmyk, jpegload
@dloebl dloebl added the bug label Nov 3, 2022
jcupitt added a commit that referenced this issue Nov 3, 2022
Detect and block a common error.

See #3139
@jcupitt
Copy link
Member

jcupitt commented Nov 3, 2022

Hi Daniel,

I added a test for this specific case, but I don't think we can do the general test we used to have :( Thanks for the report!

BTW you could write:

$ vips icc_transform --input-profile=sRGB.icm test.jpg bef.jpg sRGB.icm

As:

$ vips icc_transform --input-profile=srgb test.jpg bef.jpg srgb

Since you can use the libvips built in profile names anywhere you use a profile filename. master has p3 and cmyk as built in profiles as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants