deprecate unused option --delete #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh dear, I'm very sorry you wasted time on this. Looking back, it seems that the "delete" option was removed when thumbnail became a vips operation (rather than a separate program), and that was back in 2016. I think the current recommended equivalent would be: I'll have a look at the related docs. Thank you for fixing this! |
jcupitt
added a commit
that referenced
this pull request
May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch assumes that the --delete option of vipsthumbnail has been ignored by intend. If that's the case it should be hidden, to not cost someone else an hour.