Skip to content

Commit

Permalink
m4: Don't enable bash-completion by default
Browse files Browse the repository at this point in the history
Due to the way that check logic was written we basically enabled
bash completion whenever readline was enabled. This is not right
because it made bash-completion pkg-config module required.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
  • Loading branch information
zippy2 committed Jan 12, 2018
1 parent b1afeda commit 72ac507
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions m4/virt-bash-completion.m4
Expand Up @@ -30,14 +30,10 @@ AC_DEFUN([LIBVIRT_CHECK_BASH_COMPLETION], [
AC_REQUIRE([LIBVIRT_CHECK_READLINE])
if test "x$with_readline" != "xyes" ; then
if test "x$with_bash_completion" != "xyes" ; then
with_bash_completion=no
else
if test "x$with_bash_completion" = "xyes" ; then
AC_MSG_ERROR([readline is required for bash completion support])
fi
else
if test "x$with_bash_completion" = "xcheck" ; then
with_bash_completion=yes
else
with_bash_completion=no
fi
fi
Expand Down

0 comments on commit 72ac507

Please sign in to comment.