enable the kvm_legacy to fetch multicpu reg info #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable in subdirectories cannot be found in parent subdirectories. That is, even if LibvmiRequest is found, HAVE_LIBVMI_REQUEST cannot be defined in config.h. It is a first-aid fix and the coding in cmake is not very pretty after the fix. I think the /CMakeLists.txt , /libvmi/CMakeLists.txt , and /cmake/modules/*.cmake should be optimized throughly in the future.
In kvm_legacy.c, there is a function 'ceil', which needs the library 'libm'. It seems that, without HAVE_LIBVMI_REQUEST, the branch to the function 'ceil' will be optimized by gcc. When I use cmake to test kvm_legacy with HAVE_LIBVMI_REQUEST(after I fix another bug), I meet the error with unreferenced symbol 'ceil'. To add the link library 'libm' can resolve it.
bug fix: set HAVE_LIBVMI_REQUEST ON while find it
update to latest virsion
In kvm_legacy mode, the vmi_get_vcpureg API can only fetch reg info with cpu 0 because the inner implement unuse the argument "vcpu". The patch make up the flaw.
The commit is accidently done. Undo it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kvm_legacy mode, the vmi_get_vcpureg API can only fetch reg info with cpu 0 because the inner implement does not use the argument "vcpu".
The patch make up the flaw.