Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build system for debian 9.12 #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix build system for debian 9.12 #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libvmi/libvmi_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def check_header(header):

includes = []
includes.extend(glib_includes)
includes.extend(["/usr/local/include"])
Copy link
Contributor

@tklengyel tklengyel Feb 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding this path doesn't look right to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have any better idea? I am not familiar with this build system and just adding the default installation path should not hurt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally you want to detect the path that's required based on dependencies. I don't know anything about the python build system though. /cc @Wenzel


libs = []
libs.extend(libvmi_libs)
Expand All @@ -73,6 +74,7 @@ def check_header(header):
CDEF_HEADERS.append('events_cdef.h')

c_header_source = '\n'.join(['#include '+source for source in VMI_SOURCES])
c_header_source += "\n#include <glib.h>"
print(c_header_source)

# set source
Expand Down