try hard to make a usable file name #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #124 Setting LC_ALL=C reveals that HTTP::Response::filename created unusable file names. Use Encode's fallback coderef to make a URI encoded name when the plain character does not work. Practice with dwheeler's encodef has shown this is the least interference-prone encoding scheme.
|
Thanks @daxim! Test failures are on the Changes file, so that's fine. |
|
It's still nice for the pull request to include an update to that file,
though :)
…On Fri, Feb 1, 2019 at 7:14 AM Olaf Alders ***@***.***> wrote:
Thanks @daxim <https://github.com/daxim>! Test failures are on the
Changes file, so that's fine.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#125 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASfy8bMrxPDJ3WvAW45AGzfapyilbLQks5vJFnRgaJpZM4adTL7>
.
|
|
it's sad to see |
vanHoesel
approved these changes
Feb 4, 2019
|
Thanks @daxim and @vanHoesel! |
|
It looks like this is failing on some Windows smokers: http://www.cpantesters.org/cpan/report/6701095a-6f6e-1014-afc7-a9a7c14c3d8c Compare http://matrix.cpantesters.org/?dist=HTTP-Message+6.20-TRIAL and http://matrix.cpantesters.org/?dist=HTTP-Message+6.18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #124
Setting LC_ALL=C reveals that HTTP::Response::filename created unusable file
names. Use Encode's fallback coderef to make a URI encoded name when the plain
character does not work. Practice with dwheeler's encodef has shown this is
the least interference-prone encoding scheme.